netdev - Re: [PATCH v2 net-next 0/3] ipvlan: Deduplicate ipv4/ipv6 addr_validator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXeC6hmPiaviXcIx@horms.kernel.org>
Date: Mon, 26 Jan 2026 15:06:18 +0000
From: Simon Horman <horms@...nel.org>
To: Dmitry Skorodumov <dskr99@...il.com>
Cc: netdev@...r.kernel.org,
	Dmitry Skorodumov <skorodumov.dmitry@...wei.com>
Subject: Re: [PATCH v2 net-next 0/3] ipvlan: Deduplicate ipv4/ipv6
 addr_validator_event code

On Fri, Jan 23, 2026 at 08:03:53PM +0300, Dmitry Skorodumov wrote:
> This is a bit stylish patches: The code to handle ipv4 and ipv6
> address change are exactly the same. We don't need separate
> functions for them. Just look whether we are called
> with ipvlan_addr4_notifier_block or with ipvlan_addr6_notifier_block
> 
> The changed functionality is already covered
> with existing selftests/net/ipvtap_test.sh

Hi Dmitry,

I'm somewhat ambivalent towards the trade-off between
reducing code duplication, and requiring run-time demuxing
between ipv4 and ipv4 code paths and the moderate increase in
code complexity that entails.

But assuming these paths are not performance sensitive I guess
that reducing duplication has the upper hand.

Reviewed-by: Simon Horman <horms@...nel.org>