netdev - Re: [v4,1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260126152430.1390514-1-horms@kernel.org>
Date: Mon, 26 Jan 2026 15:24:30 +0000
From: Simon Horman <horms@...nel.org>
To: dan.carpenter@...aro.org
Cc: Simon Horman <horms@...nel.org>,
	robh@...nel.org,
	kuba@...nel.org,
	festevam@...il.com,
	ghennadi.procopciuc@....nxp.com,
	alexandre.torgue@...s.st.com,
	linux-kernel@...r.kernel.org,
	andrew+netdev@...n.ch,
	shawnguo@...nel.org,
	mbrugger@...e.com,
	mcoquelin.stm32@...il.com,
	linaro-s32@...aro.org,
	davem@...emloft.net,
	s.hauer@...gutronix.de,
	edumazet@...gle.com,
	linux-arm-kernel@...ts.infradead.org,
	imx@...ts.linux.dev,
	conor+dt@...nel.org,
	krzk+dt@...nel.org,
	devicetree@...r.kernel.org,
	Frank.li@....com,
	chester62515@...il.com,
	netdev@...r.kernel.org,
	kernel@...gutronix.de,
	pabeni@...hat.com,
	jan.petrous@....nxp.com,
	linux-stm32@...md-mailman.stormreply.com,
	s32@....com
Subject: Re: [v4,1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL_RGMII

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
    net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL_RGMII

This commit adds syscon/regmap support for accessing the GMAC_0_CTRL_STS
register on s32 chipsets, while maintaining backwards compatibility with
the existing direct MMIO approach for older device trees.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c
> index 5a485ee98fa7..2e6bb41f49e1 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c

[ ... ]

> @@ -40,7 +44,10 @@ struct s32_priv_data {
>
>  static int s32_gmac_write_phy_intf_select(struct s32_priv_data *gmac)
>  {
> -	writel(S32_PHY_INTF_SEL_RGMII, gmac->ctrl_sts);
> +	if (gmac->ctrl_sts)
> +		writel(S32_PHY_INTF_SEL_RGMII, gmac->ctrl_sts);
> +	else
> +		regmap_write(gmac->sts_regmap, gmac->sts_offset, S32_PHY_INTF_SEL_RGMII);

Should the regmap_write() return value be checked here? The function
returns int and the caller s32_gmac_init() checks the return value
expecting errors to be propagated. For comparison, dwmac-sun55i.c in
sun55i_gmac200_set_syscon() does check regmap_write() return value:

    ret = regmap_write(regmap, SYSCON_REG, reg);
    if (ret < 0)
        return dev_err_probe(dev, ret, "Failed to write to syscon\n");

>
>  	dev_dbg(gmac->dev, "PHY mode set to %s\n", phy_modes(*gmac->intf_mode));
>
>  	return 0;

[ ... ]