netdev - Re: [Intel-wired-lan] [PATCH] i40e: add an error handling path in i40e_xsk_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4eae4d1a-8043-4186-bd38-87f47dd35eda@molgen.mpg.de>
Date: Mon, 26 Jan 2026 17:51:35 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] i40e: add an error handling path in
 i40e_xsk_pool_enable()

Dear Haoxiang,


Thank you for your patch.

Am 25.01.26 um 15:04 schrieb Haoxiang Li:
> In i40e_xsk_pool_enable(), the memory allocated by 
> xsk_pool_dma_map() should be released if some error occurs. Add an
> error handling path to do so.

(Please be aware to use the fully allowed text width of 75 characters
per line. (It wouldn’t save a line here though.))

Please add a Fixes: tag.

> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn> --- drivers/
> net/ethernet/intel/i40e/i40e_xsk.c | 12 ++++++++---- 1 file changed,
> 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/
> net/ethernet/intel/i40e/i40e_xsk.c index 9f47388eaba5..92b853a75b28
> 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c +++ b/
> drivers/net/ethernet/intel/i40e/i40e_xsk.c @@ -108,23 +108,27 @@
> static int i40e_xsk_pool_enable(struct i40e_vsi *vsi, if
> (if_running) { err = i40e_queue_pair_disable(vsi, qid); if (err) -
> return err; +			goto unmap;
> 
> err = i40e_realloc_rx_xdp_bi(vsi->rx_rings[qid], true); if (err) -
> return err; +			goto unmap;
> 
> err = i40e_queue_pair_enable(vsi, qid); if (err) -			return err; +
> goto unmap;
> 
> /* Kick start the NAPI context so that receiving will start */ err =
> i40e_xsk_wakeup(vsi->netdev, qid, XDP_WAKEUP_RX); if (err) -
> return err; +			goto unmap; }
> 
> return 0; + +unmap: +	xsk_pool_dma_unmap(pool, I40E_RX_DMA_ATTR); +
> return err; }
> 
> /**


Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul