netdev - Re: [PATCH net-next v3] net: usb: remove unnecessary get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ecnb1ox9.fsf@dell.be.48ers.dk>
Date: Tue, 27 Jan 2026 08:43:14 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org,  linux-usb@...r.kernel.org,  Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>,  Andrew Lunn <andrew+netdev@...n.ch>,
  "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo Abeni
 <pabeni@...hat.com>,  Petko Manolov <petkan@...leusys.com>,  Steve
 Glendinning <steve.glendinning@...well.net>,
  UNGLinuxDriver@...rochip.com,  Nikita Zhandarovich
 <n.zhandarovich@...tech.ru>,  Oliver Neukum <oneukum@...e.com>,  Krzysztof
 Hałasa <khalasa@...p.pl>,  Deepanshu Kartikey
 <kartikey406@...il.com>,
  Oleksij Rempel <o.rempel@...gutronix.de>,  Max Schulze
 <max.schulze@...ine.de>,  Thomas Gleixner <tglx@...nel.org>,  Ingo Molnar
 <mingo@...nel.org>,  "Gustavo A. R. Silva" <gustavoars@...nel.org>,  Kees
 Cook <kees@...nel.org>,  Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH net-next v3] net: usb: remove unnecessary get_drvinfo
 code and driver versions

>>>>> "Ethan" == Ethan Nelson-Moore <enelsonmoore@...il.com> writes:

 > Many USB network drivers define get_drvinfo functions which add no
 > value over usbnet_get_drvinfo, only setting the driver name and
 > version. usbnet_get_drvinfo automatically sets the driver name, and
 > separate driver versions are now frowned upon in the kernel. Remove all
 > driver versions and replace these get_drvinfo functions with references
 > to usbnet_get_drvinfo where possible. Where that is not possible,
 > remove unnecessary code to set the driver name. Also remove two
 > unnecessary initializations from aqc111_get_drvinfo, an inaccurate
 > comment in pegasus.c, and an unused macro in catc.c.

 > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
 > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@...il.com>
 > ---
 > Changes in v3:
 > Add changelog
 > Add received Reviewed-by tag

 > Changes in v2:
 > Also remove driver versions from smsc[79]5xx (missed in the original
 > patch because they had a version definition but didn't use it in
 > get_drvinfo)

Reviewed-by: Peter Korsgaard <peter@...sgaard.com> (for dm9601.c)

-- 
Bye, Peter Korsgaard