netdev - Re: [v4,1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXh9lcfw6D6KouI_@stanley.mountain>
Date: Tue, 27 Jan 2026 11:55:49 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Simon Horman <horms@...nel.org>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, robh@...nel.org,
	kuba@...nel.org, festevam@...il.com,
	ghennadi.procopciuc@....nxp.com, alexandre.torgue@...s.st.com,
	linux-kernel@...r.kernel.org, andrew+netdev@...n.ch,
	shawnguo@...nel.org, mbrugger@...e.com, mcoquelin.stm32@...il.com,
	linaro-s32@...aro.org, davem@...emloft.net, s.hauer@...gutronix.de,
	edumazet@...gle.com, linux-arm-kernel@...ts.infradead.org,
	imx@...ts.linux.dev, conor+dt@...nel.org, krzk+dt@...nel.org,
	devicetree@...r.kernel.org, Frank.li@....com,
	chester62515@...il.com, netdev@...r.kernel.org,
	kernel@...gutronix.de, pabeni@...hat.com, jan.petrous@....nxp.com,
	linux-stm32@...md-mailman.stormreply.com, s32@....com
Subject: Re: [v4,1/3] net: stmmac: s32: use a syscon for
 S32_PHY_INTF_SEL_RGMII

On Mon, Jan 26, 2026 at 04:01:27PM +0000, Simon Horman wrote:
> But at any rate, I think the key question is should the case
> where regmap_write() returns an error be handled in
> s32_gmac_write_phy_intf_select() (by some means)?

Generally if register read/writes fail then there is nothing you
can do a the software level, you need to buy a new computer.  However,
in this case we may eventually put the registers behind an SCMI
interface so probably checking is a good idea.

Could I leave the error message out?  The callers has an error
message and if you ever see the error message, and even with SCMI,
the fix is probably still to buy a new computer.

regards,
dan carpenter