netdev - Re: [PATCH net-next] net: usb: sr9700: remove code to drive nonexistent multicast filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXi16M51PIYl1vfR@horms.kernel.org>
Date: Tue, 27 Jan 2026 12:56:08 +0000
From: Simon Horman <horms@...nel.org>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Peter Korsgaard <peter@...sgaard.com>
Subject: Re: [PATCH net-next] net: usb: sr9700: remove code to drive
 nonexistent multicast filter

On Mon, Jan 26, 2026 at 09:37:48PM -0800, Ethan Nelson-Moore wrote:
> On Mon, Jan 26, 2026 at 5:42 AM Simon Horman <horms@...nel.org> wrote:
> > I would slightly lean towards splitting this patch up,
> > say one for the multicast changes and removal of related #defines,
> > and another for the remainder of the #define clean-up.
> >
> > But that notwithstanding this looks good to me.
> >
> > Reviewed-by: Simon Horman <horms@...nel.org>
> 
> Hi, Simon,
> 
> Thanks for your feedback.
> Would it be appropriate for me to reuse your Reviewed-by tag for my
> split patch? (The only other change is to use netdev_mc_empty instead
> of checking if netdev_mc_count > 0.)

Yes, that is fine.
Thanks for asking.