netdev - Re: [Intel-wired-lan] [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8807b34-59d9-4b8c-8b2e-477fa25ef413@molgen.mpg.de>
Date: Tue, 27 Jan 2026 17:21:12 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Simon Horman <horms@...nel.org>
Cc: intel-wired-lan@...ts.osuosl.org, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Richard Cochran <richardcochran@...il.com>,
 netdev@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Make name member of
 struct ice_cgu_pin_desc const

Dear Simon,


Thank you for your patch.

Am 27.01.26 um 17:16 schrieb Simon Horman:
> The name member of struct ice_cgu_pin_desc never modified.
> Make it const.
> 
> Found by inspection.
> Compile tested only.
> 
> Signed-off-by: Simon Horman <horms@...nel.org>
> ---
>   drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> index 93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc00e06f26cab5c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.h
> @@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins {
>   };
>   
>   struct ice_cgu_pin_desc {
> -	char *name;
> +	const char *name;
>   	u8 index;
>   	enum dpll_pin_type type;
>   	u32 freq_supp_num;
Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul Menzel