netdev - Re: [PATCH net-next v5 3/7] ipv6: Add case for IPV6_TLV_TNL_ENCAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c06b2a3-431e-4fe0-a09c-7281579167d3@gmail.com>
Date: Tue, 27 Jan 2026 18:52:20 +0100
From: Justin Iurman <justin.iurman@...il.com>
To: Tom Herbert <tom@...bertland.com>, davem@...emloft.net, kuba@...nel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 3/7] ipv6: Add case for
 IPV6_TLV_TNL_ENCAP_LIMIT in EH TLV switch



On 1/26/26 20:48, Tom Herbert wrote:
> IPV6_TLV_TNL_ENCAP_LIMIT is a recognized Destination option that is
> processed in ip_tunnel.c. Add a case for it in the switch in
> ip6_parse_tlv so that it is recognized as a known option.
> 
> Also remove the unlikely around the check for max_count < 0 since the
> default limits for HBH and Destination options can be less than zero.
> 
> Signed-off-by: Tom Herbert <tom@...bertland.com>
> ---
>   net/ipv6/exthdrs.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
> index b9d186784b96..6925cfad94d2 100644
> --- a/net/ipv6/exthdrs.c
> +++ b/net/ipv6/exthdrs.c
> @@ -122,7 +122,7 @@ static bool ip6_parse_tlv(bool hopbyhop,
>   	int tlv_count = 0;
>   	int padlen = 0;
>   
> -	if (unlikely(max_count < 0)) {
> +	if (max_count < 0) {
>   		disallow_unknowns = true;
>   		max_count = -max_count;
>   	}
> @@ -202,6 +202,16 @@ static bool ip6_parse_tlv(bool hopbyhop,
>   					if (!ipv6_dest_hao(skb, off))
>   						return false;
>   					break;
> +#endif
> +#if IS_ENABLED(CONFIG_IPV6_TUNNEL)
> +				case IPV6_TLV_TNL_ENCAP_LIMIT:
> +					/* The tunnel encapsulation option.
> +					 * This is handled in ip6_tunnel.c so
> +					 * we don't need to do anything here
> +					 * except to accept it as a recognized
> +					 * option
> +					 */
> +					break;
>   #endif
>   				default:
>   					if (!ip6_tlvopt_unknown(skb, off,

Reviewed-by: Justin Iurman <justin.iurman@...il.com>