netdev - Re: [PATCH iwl-next v2 1/2] ixgbe: e610: Convert ACI descriptor buffer to little endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3193abf-e758-4ee8-995b-72d850f99c1a@intel.com>
Date: Tue, 27 Jan 2026 10:51:05 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Kwapulinski, Piotr" <piotr.kwapulinski@...el.com>, "Keller, Jacob E"
	<jacob.e.keller@...el.com>, Simon Horman <horms@...nel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dan.carpenter@...aro.org"
	<dan.carpenter@...aro.org>, "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>,
	"Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
Subject: Re: [PATCH iwl-next v2 1/2] ixgbe: e610: Convert ACI descriptor
 buffer to little endian



On 1/27/2026 3:31 AM, Kwapulinski, Piotr wrote:

...

>>>> @@ -145,7 +146,7 @@ static int ixgbe_aci_send_cmd_execute(struct
>>> ixgbe_hw *hw,
>>>>   	if ((hicr & IXGBE_PF_HICR_SV)) {
>>>>   		for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) {
>>>>   			raw_desc[i] = IXGBE_READ_REG(hw,
>>> IXGBE_PF_HIDA(i));
>>>> -			raw_desc[i] = raw_desc[i];
>>>
>>> I'm also curious to know what the intent (if any) of the line above was/is.

...
> will drop this patch,

Could we remove the raw_desc redundant assignment though? I think 
there's one other instance nearby. You can send it separately and I'll 
make it part of the same series as the other patch when it goes to netdev.

Thanks,
Tony