netdev - Re: [PATCH net-next v2] net: ethernet: neterion: s2io: remove unused driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260127155607.3f80ec99@kernel.org>
Date: Tue, 27 Jan 2026 15:56:07 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Maciej W. Rozycki" <macro@...am.me.uk>
Cc: Ethan Nelson-Moore <enelsonmoore@...il.com>, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-s390@...r.kernel.org, Jonathan Corbet
 <corbet@....net>, Linas Vepstas <linasvepstas@...il.com>, Mahesh J
 Salgaonkar <mahesh@...ux.ibm.com>, Oliver O'Halloran <oohall@...il.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Thomas Bogendoerfer
 <tsbogend@...ha.franken.de>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 "Christophe Leroy (CS GROUP)" <chleroy@...nel.org>, Heiko Carstens
 <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, Andrew Morton <akpm@...ux-foundation.org>,
 Martin Kepplinger-Novaković <martink@...teo.de>, Pavel
 Machek <pavel@....cz>, MD Danish Anwar <danishanwar@...com>, Mengyuan Lou
 <mengyuanlou@...-swift.com>, Pablo Neira Ayuso <pablo@...filter.org>,
 Takashi Iwai <tiwai@...e.de>, Huacai Chen <chenhuacai@...nel.org>, Theodore
 Ts'o <tytso@....edu>, Eric Biggers <ebiggers@...gle.com>, Madadi Vineeth
 Reddy <vineethr@...ux.ibm.com>, Shrikanth Hegde <sshegde@...ux.ibm.com>,
 Geert Uytterhoeven <geert@...ux-m68k.org>, Ard Biesheuvel
 <ardb@...nel.org>, "Martin K. Petersen" <martin.petersen@...cle.com>,
 Frederic Barrat <fbarrat@...ux.ibm.com>, Andrew Donnellan
 <ajd@...ux.ibm.com>, Herbert Xu <herbert@...dor.apana.org.au>, Konstantin
 Shkolnyy <kshk@...ux.ibm.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Lukas Bulwahn
 <lukas.bulwahn@...hat.com>, Dong Yibo <dong100@...se.com>, Heiner Kallweit
 <hkallweit1@...il.com>, Thomas Gleixner <tglx@...nel.org>, Ingo Molnar
 <mingo@...nel.org>, Lukas Wunner <lukas@...ner.de>, Giovanni Cabiddu
 <giovanni.cabiddu@...el.com>
Subject: Re: [PATCH net-next v2] net: ethernet: neterion: s2io: remove
 unused driver

On Tue, 27 Jan 2026 01:19:34 +0000 (GMT) Maciej W. Rozycki wrote:
> > highly unlikely that this driver is still being used. Remove the
> > driver, and move the former maintainer to the CREDITS file (restoring
> > credit for the vxge driver, which was removed in commit f05643a0f60b
> > ("eth: remove neterion/vxge").  
> 
>  How do you know it's not used? 

Hard to prove a negative and whatnot.

We deleted the vxge which I think(?) was for a newer version of this HW
3+ years ago and nobody complained. 

> What's the gain from removing a driver unless say it's broken and
> does not build?

People keep sending cleanups and fixes for these old drivers.
It takes time to review that stuff.