netdev - Re: [PATCH net-next 3/3] tcp: move tcp_rack_advance() to tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUCT8BeAU60JnOsP4bp6hBhxYcNZPmCgaq-zAreePsvNGQ@mail.gmail.com>
Date: Mon, 26 Jan 2026 19:29:06 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Neal Cardwell <ncardwell@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/3] tcp: move tcp_rack_advance() to tcp_input.c

On Mon, Jan 26, 2026 at 7:21 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> tcp_rack_advance() is called from tcp_ack() and tcp_sacktag_one().
>
> Moving it to tcp_input.c allows the compiler to inline it and save
> both space and cpu cycles in TCP fast path.
>
> $ scripts/bloat-o-meter -t vmlinux.1 vmlinux.2
> add/remove: 0/2 grow/shrink: 1/1 up/down: 98/-132 (-34)
> Function                                     old     new   delta
> tcp_ack                                     5741    5839     +98
> tcp_sacktag_one                              407     395     -12
> __pfx_tcp_rack_advance                        16       -     -16
> tcp_rack_advance                             104       -    -104
> Total: Before=22572680, After=22572646, chg -0.00%
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>