netdev - Re: [PATCH net-next] declance: Remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260126194054.79e6f56d@kernel.org>
Date: Mon, 26 Jan 2026 19:40:54 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] declance: Remove IRQF_ONESHOT

On Fri, 23 Jan 2026 12:06:16 +0100 Sebastian Andrzej Siewior wrote:
> Passing IRQF_ONESHOT ensures that the interrupt source is masked until
> the secondary (threaded) handler is done. If only a primary handler is
> used then the flag makes no sense because the interrupt can not fire
> (again) while its handler is running.
> The flag also disallows force-threading of the primary handler and the
> irq-core will warn about this.
> 
> Remove IRQF_ONESHOT to irqflags.
> 
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
> 
> lance_dma_merr_int() does nothing but a printk() which means if it is a
> level interrupt then once it fires it remains asserted and that printk()
> takes over the machine.
> I guess it never fires and is just left over debug.

have you seen 0fabe1021f8bc9cffdede4ddad0dd04d43c5166c ?
Sounds like it may have been a hack local to MIPS.
On a quick read indeed your changes seems fine but it would give us
certain warm and fuzzies to have the commit message refer to and 
reason about the patch that introduced the flag..
-- 
pw-bot: cr