netdev - Re: [PATCH net-next 3/3] net: usb: kaweth: remove eth_addr_t typedef and bcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADkSEUjgRrC9eAQYOkaErd7wyXKkUs7+dG+Q1jz7VbqF+zxwuw@mail.gmail.com>
Date: Mon, 26 Jan 2026 20:38:54 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
To: Oliver Neukum <oneukum@...e.com>
Cc: netdev@...r.kernel.org, linux-usb@...r.kernel.org, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] net: usb: kaweth: remove eth_addr_t typedef
 and bcast_addr definition

On Mon, Jan 26, 2026 at 3:49 AM Oliver Neukum <oneukum@...e.com> wrote:
>   * Please note: addr must be aligned to u16.
>   */
>
> That requirement is not met. This code will bomb on ARM for example.

Hi, Oliver,

Thanks for noticing this.

It seems like no one is using this driver; there is only one hardware
probe submission on linux-hardware.org containing any device ID
supported by kaweth (of 0557:2002, from Debian 12 on Pentium III
hardware). Therefore, it doesn't make sense to clean it up.

Admittedly, that is only one source, and the number of submissions to
it has dropped recently because it has been having server issues, but
it's still a useful data point.

In comparison, here are the numbers of submissions for a few other devices:
r8152: 0bda:8152 - 1372 (did not check other device IDs)
rtl8150: 0bda:8150 - 18 (did not check other device IDs)
mcs7830: 20 (19 9710:7830, 1 9710:7832)
sr9700: 221 (161 0fe6:9700, 60 0fe6:9702 which I recently added)
sr9800: 0 (I will send a follow-up email regarding next steps to take
regarding this driver)

Hope that helps you get a sense of how much these drivers are being used.

Ethan