netdev - Re: [net-next 0/6] move CAN skb headroom content to skb extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f131acda-1a26-4f88-96ef-88a419e1170a@hartkopp.net>
Date: Wed, 28 Jan 2026 17:34:21 +0100
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: Florian Westphal <fw@...len.de>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
 linux-can@...r.kernel.org
Subject: Re: [net-next 0/6] move CAN skb headroom content to skb extensions



On 28.01.26 17:25, Florian Westphal wrote:
> Oliver Hartkopp <socketcan@...tkopp.net> wrote:

>> But thinking about BUILD_BUG_ON(skb_ext_total_length() > 255):
>>
>> Shouldn't this be SKB_EXT_CHUNKSIZEOF(struct skb_ext) + sum of the skb
>> ext user data which can be up to 255 *  SKB_EXT_ALIGN_VALUE (= 2040) ???
> 
> Why?  Its not about the size in bytes, its there to make sure
> ext->offset[] (u8) won't overflow for any of the extensions.
> 
> Maybe a comment would help.

Oh I misread SKB_EXT_CHUNKSIZEOF m(

My bad. Sorry for the noise.

Best regards,
Oliver