netdev - Re: [PATCH 0/2] virtio_net: add page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559206f7-6fa1-4326-ba85-ae8ca405f71c@meta.com>
Date: Wed, 28 Jan 2026 12:27:30 -0800
From: Vishwanath Seshagiri <vishs@...a.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Eugenio Pérez <eperezma@...hat.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S . Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, David Wei <dw@...idwei.uk>,
        netdev@...r.kernel.org, virtualization@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] virtio_net: add page_pool support



On 1/28/26 12:19 PM, Michael S. Tsirkin wrote:
> > 
> On Wed, Jan 07, 2026 at 09:23:46PM -0800, Vishwanath Seshagiri wrote:
>> On 1/7/26 12:28 AM, Michael S. Tsirkin wrote:
>>> On Tue, Jan 06, 2026 at 02:19:22PM -0800, Vishwanath Seshagiri wrote:
>>>> Introduce page_pool support in virtio_net driver in order to recycle
>>>> pages in RX buffer allocation and avoid reallocating through the page
>>>> allocator. This applies to mergeable and small buffer modes.
>>>>
>>>> The patch has been tested using the included selftests and additional
>>>> edge case scripts covering device unbind/bind cycles, rapid interface
>>>> open/close, traffic during close, ethtool stress with feature toggling,
>>>> close with pending refill work, and data integrity verification.
>>>
>>>
>>> Yay! thanks for working on this!
>>> Could you share perf data please?
>>> After all, page pool is an optimization.
>>
>> Thanks! I'll add benchmark numbers in v2 of the patch.
> 
> This never came, or did I miss it?

It is ready, I will send it today! Had some personal stuff come up in
the middle.

> 
>> Beyond performance, page pool support is pre requisite for enabling
>> memory provider based zero copy implementations in virtio_net such as
>> devmem TCP and io-uring ZCRX. These features require the driver to use
>> page pools for buffer management. I'll update the cover letter to make
>> this motivation clearer.
>>
>>>
>>>
>>>> Vishwanath Seshagiri (2):
>>>>     virtio_net: add page pool support for buffer allocation
>>>>     selftests: virtio_net: add buffer circulation test
>>>>
>>>>    drivers/net/virtio_net.c                      | 246 +++++++++++++++---
>>>>    .../drivers/net/virtio_net/basic_features.sh  |  70 +++++
>>>>    2 files changed, 275 insertions(+), 41 deletions(-)
>>>>
>>>> -- 
>>>> 2.47.3
>>>
>