netdev - Re: [RFC PATCH] net: phy: integrate reset-after-clock quirk into phy_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOf5uwkr0Rmb_x0U88JAfozCQpkOoFOZ-V7BNteVZfcnNQF-Lw@mail.gmail.com>
Date: Wed, 28 Jan 2026 22:04:03 +0100
From: Michael Nazzareno Trimarchi <michael@...rulasolutions.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Marco Felsch <m.felsch@...gutronix.de>, 
	"Russell King (Oracle)" <linux@...linux.org.uk>, Wei Fang <wei.fang@....com>, 
	Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Heiner Kallweit <hkallweit1@...il.com>, 
	"open list:FREESCALE IMX / MXC FEC DRIVER" <imx@...ts.linux.dev>, 
	"open list:FREESCALE IMX / MXC FEC DRIVER" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] net: phy: integrate reset-after-clock quirk into phy_init_hw

Hi

On Wed, Jan 28, 2026 at 9:51 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > The issue was with the out-of-band reset coming from the FEC driver
> > which doesn't honor the phy state-machine.
>
> Could you explain this is more details. Is the FEC doing something
> wrong?

The fact that the phy should be reset when the clk is provided to it, is not
connected at all with the fec. I think that fec_main does not register itself
as clock provider, You "should" define the phy to have a clock if this is needed
during the restoration and we should not give any "magic" at controller level.

* Marco * Your commit bedd8d78aba300860cec3f85d6ff549b3b7f2679 is clear
and I have tried to use it but if I remember the problem is the clock
is provided
by the ethernet controller.

Michael


>
>         Andrew



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@...rulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@...rulasolutions.com
www.amarulasolutions.com