netdev - 回复：[PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17b1ca50-a9e4-499c-b84b-b8223c313491.illusion.wang@nebula-matrix.com>
Date: Wed, 28 Jan 2026 10:46:51 +0800
From: "Illusion Wang" <illusion.wang@...ula-matrix.com>
To: "Jakub Kicinski" <kuba@...nel.org>,
  "Simon Horman" <horms@...nel.org>
Cc: "Dimon" <dimon.zhao@...ula-matrix.com>,
  "Alvin" <alvin.wang@...ula-matrix.com>,
  "Sam" <sam.chen@...ula-matrix.com>,
  "netdev" <netdev@...r.kernel.org>,
  "andrew+netdev" <andrew+netdev@...n.ch>,
  "corbet" <corbet@....net>,
  "linux-doc" <linux-doc@...r.kernel.org>,
  "lorenzo" <lorenzo@...nel.org>,
  "pabeni" <pabeni@...hat.com>,
  "vadim.fedorenko" <vadim.fedorenko@...ux.dev>,
  "lukas.bulwahn" <lukas.bulwahn@...hat.com>,
  "hawk" <hawk@...nel.org>,
  "ast" <ast@...nel.org>,
  "bpf" <bpf@...r.kernel.org>,
  "sdf" <sdf@...ichev.me>,
  "daniel" <daniel@...earbox.net>,
  "john.fastabend" <john.fastabend@...il.com>,
  "edumazet" <edumazet@...gle.com>,
  "open list" <linux-kernel@...r.kernel.org>
Subject: 回复：[PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs


Thank you for your feedback

patch3 primarily includes code that does not require extensive review,
such as the message codes and message body structures defined in
nbl_def_channel.h. These components are generally stable and
used for PF/VF communication, which is why they were initially
included in Patch 3. However, based on review feedback, I will
extract these manually written communication protocol definitions.

Additionally, I will make another round of comprehensive code
reduction to meet the submission requirements as much as possible.


------------------------------------------------------------------
发件人：Jakub Kicinski <kuba@...nel.org>
发送时间：2026年1月28日(周三) 02:53
收件人：Simon Horman<horms@...nel.org>; Illusion Wang<illusion.wang@...ula-matrix.com>
抄　送：Dimon<dimon.zhao@...ula-matrix.com>; Alvin<alvin.wang@...ula-matrix.com>; Sam<sam.chen@...ula-matrix.com>; netdev<netdev@...r.kernel.org>; "andrew+netdev"<andrew+netdev@...n.ch>; corbet<corbet@....net>; "linux-doc"<linux-doc@...r.kernel.org>; lorenzo<lorenzo@...nel.org>; pabeni<pabeni@...hat.com>; "vadim.fedorenko"<vadim.fedorenko@...ux.dev>; "lukas.bulwahn"<lukas.bulwahn@...hat.com>; hawk<hawk@...nel.org>; ast<ast@...nel.org>; bpf<bpf@...r.kernel.org>; sdf<sdf@...ichev.me>; daniel<daniel@...earbox.net>; "john.fastabend"<john.fastabend@...il.com>; edumazet<edumazet@...gle.com>; open list<linux-kernel@...r.kernel.org>
主　题：Re: [PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs


On Tue, 27 Jan 2026 18:06:49 +0000 Simon Horman wrote:
> As per Jakub's advice in his review of v1 [*],
> Please try to create a minimal driver in the order of ~5kLoC.

Perhaps other maintainers will disagree, but for ease of review
and to avoid the huge reposts perhaps we should consider merging
something like patches 1 and 3* first, as the initial series.
And then you can build up the driver from there in reasonable,
5kLoC-at-a-time series?

 * patch 3 currently includes things which do not seem machine
   generated / like register descriptors like structs added to
   nbl_def_channel.h and nbl_include.h