netdev - Re: [PATCH net v3] net: cpsw_new: Execute ndo_set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260127190836.6a420768@kernel.org>
Date: Tue, 27 Jan 2026 19:08:36 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kevin Hao <haokexin@...il.com>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org, Siddharth Vadapalli
 <s-vadapalli@...com>, Roger Quadros <rogerq@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Vladimir
 Oltean <vladimir.oltean@....com>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 linux-omap@...r.kernel.org
Subject: Re: [PATCH net v3] net: cpsw_new: Execute ndo_set_rx_mode callback
 in a work queue

On Tue, 27 Jan 2026 16:02:07 +0800 Kevin Hao wrote:
> To resolve this issue, we opt to execute the actual processing within
> a work queue, following the approach used by the icssg-prueth driver.

Code looks good now, but why are you creating a workqueue for this one
work? Can't you use the system wq and just cancel it sync where you had
the wq destroy?

BTW you're fixing drivers/net/ethernet/ti/cpsw_new.c I think
drivers/net/ethernet/ti/cpsw.c has an identical bug, no?
-- 
pw-bot: cr