netdev - Re: [net-next v8 3/8] net: wwan: core: split port creation and registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62793715-5fcb-470d-85dd-77472e410df3@redhat.com>
Date: Thu, 29 Jan 2026 12:46:47 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Slark Xiao <slark_xiao@....com>, loic.poulain@....qualcomm.com,
 ryazanov.s.a@...il.com, johannes@...solutions.net, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, mani@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next v8 3/8] net: wwan: core: split port creation and
 registration

On 1/26/26 7:21 AM, Slark Xiao wrote:
> From: Sergey Ryazanov <ryazanov.s.a@...il.com>
> 
> Upcoming GNSS (NMEA) port type support requires exporting it via the
> GNSS subsystem. On another hand, we still need to do basic WWAN core
> work: find or allocate the WWAN device, make it the port parent, etc. To
> reuse as much code as possible, split the port creation function into
> the registration of a regular WWAN port device, and basic port struct
> initialization.
> 
> To be able to use put_device() uniformly, break the device_register()
> call into device_initialize() and device_add() and call device
> initialization earlier.
> 
> While at it, fix a minor number leak upon WWAN port registration
> failure.
> 
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@...il.com>

The series LGTM, but waiting a bit more for Loic's explicit ack here.

Thanks,

Paolo