netdev - Re: [PATCH net-next v16 06/12] virtio_net: Create a FF group for ethtool steering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1aecc98e-8215-4fc7-97f6-e1247da60339@nvidia.com>
Date: Thu, 29 Jan 2026 11:08:16 -0600
From: Dan Jurgens <danielj@...dia.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: netdev@...r.kernel.org, jasowang@...hat.com, pabeni@...hat.com,
 virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
 yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 jgg@...pe.ca, kevin.tian@...el.com, kuba@...nel.org, andrew+netdev@...n.ch,
 edumazet@...gle.com
Subject: Re: [PATCH net-next v16 06/12] virtio_net: Create a FF group for
 ethtool steering

On 1/22/26 3:51 PM, Michael S. Tsirkin wrote:

>> +	ethtool_group.group_priority = cpu_to_le16(VIRTNET_FF_ETHTOOL_GROUP_PRIORITY);
>> +
>> +	/* Use priority for the object ID. */
>> +	err = virtio_admin_obj_create(vdev,
>> +				      VIRTIO_NET_RESOURCE_OBJ_FF_GROUP,
>> +				      VIRTNET_FF_ETHTOOL_GROUP_PRIORITY,
> 
> This (3rd param to virtio_admin_obj_create)
> is the object ID actually. Setting this to 1 means it is outside
> of range for group limit which should be 0...limit - 1 and limit is 1.
> 
> don't you mean 0?
>

No, the the maximum number of groups being 1 doesn't say anything about
the ID you use for that group. Higher IDs indicate higher priorities. I
intentionally choose 1 here because a reasonable follow on series would
be to implement ARFS. In that case it would make sense to have user
created rules higher priority than ARFS rules.

> 
>> +				      VIRTIO_ADMIN_GROUP_TYPE_SELF,