netdev - Re: [PATCH net-next v8 15/15] quic: add packet parser base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_eHu0=8G7--neMHz5CDT4_MV-MONRu8obOsYbUhCc1ocg@mail.gmail.com>
Date: Thu, 29 Jan 2026 14:37:51 -0500
From: Xin Long <lucien.xin@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: network dev <netdev@...r.kernel.org>, quic@...ts.linux.dev, davem@...emloft.net, 
	kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>, 
	Stefan Metzmacher <metze@...ba.org>, Moritz Buhl <mbuhl@...nbsd.org>, Tyler Fanelli <tfanelli@...hat.com>, 
	Pengtao He <hepengtao@...omi.com>, Thomas Dreibholz <dreibh@...ula.no>, linux-cifs@...r.kernel.org, 
	Steve French <smfrench@...il.com>, Namjae Jeon <linkinjeon@...nel.org>, 
	Paulo Alcantara <pc@...guebit.com>, Tom Talpey <tom@...pey.com>, kernel-tls-handshake@...ts.linux.dev, 
	Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>, 
	Steve Dickson <steved@...hat.com>, Hannes Reinecke <hare@...e.de>, Alexander Aring <aahringo@...hat.com>, 
	David Howells <dhowells@...hat.com>, Matthieu Baerts <matttbe@...nel.org>, 
	John Ericson <mail@...nericson.me>, Cong Wang <xiyou.wangcong@...il.com>, 
	"D . Wythe" <alibuda@...ux.alibaba.com>, Jason Baron <jbaron@...mai.com>, 
	illiliti <illiliti@...tonmail.com>, Sabrina Dubroca <sd@...asysnail.net>, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Daniel Stenberg <daniel@...x.se>, 
	Andy Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next v8 15/15] quic: add packet parser base

On Thu, Jan 29, 2026 at 11:53 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 1/26/26 3:51 PM, Xin Long wrote:
> > +/* Lookup listening socket for Client Initial packet (in process context). */
> > +static struct sock *quic_packet_get_listen_sock(struct sk_buff *skb)
> > +{
> > +     union quic_addr daddr, saddr;
> > +     struct quic_data alpns = {};
> > +     struct sock *sk;
> > +
> > +     quic_get_msg_addrs(skb, &daddr, &saddr);
> > +
> > +     if (quic_packet_parse_alpn(skb, &alpns))
> > +             return NULL;
> > +
> > +     local_bh_disable();
>
> Is this really needed? If so, it needs some comment explaining the
> rationale, otherwise please drop it.
>
It was needed, as a spin_lock use in quic_listen_sock_lookup(), now
it's changed to rcu_read_lock(), maybe I should drop it. will double check.

Thanks.