netdev - Re: [PATCH net V2 2/4] net/mlx5: Fix deadlock between devlink lock and esw->wq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260129154024.3915c3bf@kernel.org>
Date: Thu, 29 Jan 2026 15:40:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Cosmin Ratiu <cratiu@...dia.com>
Cc: Tariq Toukan <tariqt@...dia.com>, "andrew+netdev@...n.ch"
 <andrew+netdev@...n.ch>, "linux-rdma@...r.kernel.org"
 <linux-rdma@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>,
 Gal Pressman <gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>, Mark Bloch
 <mbloch@...dia.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "edumazet@...gle.com"
 <edumazet@...gle.com>, Saeed Mahameed <saeedm@...dia.com>,
 "horms@...nel.org" <horms@...nel.org>, "leon@...nel.org" <leon@...nel.org>
Subject: Re: [PATCH net V2 2/4] net/mlx5: Fix deadlock between devlink lock
 and esw->wq

On Thu, 29 Jan 2026 10:33:40 +0000 Cosmin Ratiu wrote:
> > This is quite an ugly hack, is there no way to avoid the flush and
> > let 
> > the work discover that what it was supposed to do is no longer
> > needed?  
> 
> Not possible, unfortunately. I stared at it for quite a while. The wq
> is flushed because the esw is being unconfigured, which removes data
> structs the work handler uses. Flushing the work is required, otherwise
> we'll run into worse issues.

And having a refount on (I presume) struct mlx5_esw_functions
so that work can hold a ref is not an option?
Are you planning to revisit this in -next?