netdev - Re: [PATCH net-next] bng_en: fix misleading error message for generic firmware version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHLZf_vxzcOpavJ-rNUsmi3XQ-NAqmWBvy2MRgGb2A3iWFHFHw@mail.gmail.com>
Date: Fri, 30 Jan 2026 14:05:18 +0530
From: Vikas Gupta <vikas.gupta@...adcom.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: bhargava.marreddy@...adcom.com, rajashekar.hudumula@...adcom.com, 
	netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next] bng_en: fix misleading error message for generic
 firmware version

On Fri, Jan 30, 2026 at 1:01 PM Alok Tiwari <alok.a.tiwari@...cle.com> wrote:
>
> The devlink info_get handler incorrectly reports "roce firmware" when
> populating the generic firmware version field.
>
> Update the error message to correctly describe the failing operation.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>  drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> index a987afebd64d..57db3caabcfb 100644
> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
>                               DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>         if (rc) {
>                 NL_SET_ERR_MSG_MOD(extack,
> -                                  "Failed to set roce firmware version");
> +                                  "Failed to set generic firmware version");

Thanks for fixing. I believe instead of generic, "Failed to set
firmware version"  is enough.

>                 return rc;
>         }
>
> --
> 2.50.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5465 bytes)