netdev - Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260129182332.040411b5@kernel.org>
Date: Thu, 29 Jan 2026 18:23:32 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: michael.chan@...adcom.com
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 pavan.chebbi@...adcom.com, asml.silence@...il.com
Subject: Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg
 defaults on old FW/HW

On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:
> The driver now depends on the core to tell it what the rx page size
> should be for the agg ring. We must populate the ndo_default_qcfg
> callback even if we don't support any queue ops.
> 
> This fixes:
>   Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
>   RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> 
> with fw version 225.1.109.0.
> 
> Link: https://lore.kernel.org/20250421222827.283737-20-kuba@kernel.org
> Fixes: f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Can I get an ack here? This prevents machines from booting so
it'd be great to fix before too many people waste their time.

> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 8fc0720c3057..466e0fc6141f 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -16316,6 +16316,7 @@ static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops = {
>  };
>  
>  static const struct netdev_queue_mgmt_ops bnxt_queue_mgmt_ops_unsupp = {
> +	.ndo_default_qcfg	= bnxt_queue_default_qcfg,
>  };
>  
>  static void bnxt_remove_one(struct pci_dev *pdev)