netdev - Re: [PATCH net v2] net: don't touch dev->stats in BPF redirect paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+ak=qy89AW22MzJFoTnqXSehGLy+uCgp24a=5K46mt9Q@mail.gmail.com>
Date: Fri, 30 Jan 2026 19:54:59 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	andrew+netdev@...n.ch, horms@...nel.org, 
	Martin KaFai Lau <martin.lau@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Gal Pressman <gal@...dia.com>, ast@...nel.org, eddyz87@...il.com, song@...nel.org, 
	yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org, 
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, dsahern@...il.com, 
	bpf@...r.kernel.org
Subject: Re: [PATCH net v2] net: don't touch dev->stats in BPF redirect paths

On Fri, Jan 30, 2026 at 4:38 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Gal reports that BPF redirect increments dev->stats.tx_errors
> on failure. This is not correct, most modern drivers completely
> ignore dev->stats so these drops will be invisible to the user.
> Core code should use the dedicated core stats which are folded
> into device stats in dev_get_stats().
>
> Note that we're switching from tx_errors to tx_dropped.
> Core only has tx_dropped, hence presumably users already expect
> that counter to increment for "stack" Tx issues.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>