netdev - Re: [net-next,v24,6/6] eea: introduce callback for ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260130233245.923444-1-kuba@kernel.org>
Date: Fri, 30 Jan 2026 15:32:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: xuanzhuo@...ux.alibaba.com
Cc: Jakub Kicinski <kuba@...nel.org>,
	lorenzo@...nel.org,
	andrew+netdev@...n.ch,
	hkallweit1@...il.com,
	dust.li@...ux.alibaba.com,
	edumazet@...gle.com,
	davem@...emloft.net,
	pabeni@...hat.com,
	lulie@...ux.alibaba.com,
	andrew@...n.ch,
	netdev@...r.kernel.org,
	guwen@...ux.alibaba.com,
	dong100@...se.com,
	lukas.bulwahn@...hat.com,
	vadim.fedorenko@...ux.dev,
	enelsonmoore@...il.com
Subject: Re: [net-next,v24,6/6] eea: introduce callback for ndo_get_stats64

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
eea: introduce callback for ndo_get_stats64

This commit adds ndo_get_stats64 support to the Alibaba Elastic Ethernet
Adapter driver and introduces a spinlock to protect concurrent access to
rx and tx pointers when gathering statistics.

The commit message says "Add basic driver framework for the Alibaba
Elastic Ethernet Adapter(EEA)." But shouldn't this say it's adding stats
support to an existing framework rather than adding the basic framework
itself? The other commits in the series appear to have already introduced
the framework.

This commit introduces a spinlock to protect against races between
eea_stats() and the queue setup/teardown functions. The race being fixed
was introduced in commit cf49df362e30 ("eea: create/destroy rx,tx queues
for netdevice open and stop"). Should this commit include a Fixes: tag?

Fixes: cf49df362e30 ("eea: create/destroy rx,tx queues for netdevice open and stop")