netdev - Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260129185119.3182f59a@kernel.org>
Date: Thu, 29 Jan 2026 18:51:19 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 pavan.chebbi@...adcom.com, asml.silence@...il.com
Subject: Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg
 defaults on old FW/HW

On Thu, 29 Jan 2026 18:36:07 -0800 Michael Chan wrote:
> On Thu, Jan 29, 2026 at 6:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:  
> > > The driver now depends on the core to tell it what the rx page size
> > > should be for the agg ring. We must populate the ndo_default_qcfg
> > > callback even if we don't support any queue ops.
> > >
> > > This fixes:
> > >   Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
> > >   RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> > >
> > > with fw version 225.1.109.0.
> > >
> > > Link: https://lore.kernel.org/20250421222827.283737-20-kuba@kernel.org
> > > Fixes: f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")
> > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>  
> >
> > Can I get an ack here? This prevents machines from booting so
> > it'd be great to fix before too many people waste their time.  
> 
> Yes, it looks good to me.  Thanks.
> Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Thank you!