netdev - Re: [PATCH net 4/4] selftests: drv-net: rss_ctx: test RSS contexts persist after ifdown/up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv1ixptJMvYn_=mhYwkxbBnLFW+TiDTxbZ3oyGbH71XTZw@mail.gmail.com>
Date: Fri, 30 Jan 2026 09:22:17 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Michael Chan <michael.chan@...adcom.com>, davem@...emloft.net, netdev@...r.kernel.org, 
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch, 
	andrew.gospodarek@...adcom.com
Subject: Re: [PATCH net 4/4] selftests: drv-net: rss_ctx: test RSS contexts
 persist after ifdown/up

> Not sure why this is a separate test, TBH. You can remove the test
> without the ntuple filters. The two cases I would have expected based
> on patches is:
>
> tests1:
>  - add a couple of contexts
>  - add a n-tuple filter to one of the context
>  - ifdown/ifup
>  - check contexts and filters are there
>  - run some traffic to make sure it flows right
>
> tests2:
>  - ifdown
>  - add a couple of contexts
>  - add a n-tuple filter to one of the context
>  - ifup
>  - check contexts and filters are there
>  - run some traffic to make sure it flows right
>

Very smart, thanks! When I see such beautiful solutions I curse myself
for not thinking about it in the first place.

> You can probably have one shared implementation and pass a param to
> it  to tell it whether to "pre-down" the interface.

Yes, Michael also did bring this point up that there is a lot of
shared code between the tests, but I tried to test my luck.
Will be back with a v2. Thanks.

> --
> pw-bot: cr

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)