netdev - Re: [PATCH net-next] net: lantiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63ecf47d-6702-49d0-b063-f2f2510ef45b@gmail.com>
Date: Fri, 30 Jan 2026 07:37:23 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Simon Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Hauke Mehrtens <hauke@...ke-m.de>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 OpenWrt Development List <openwrt-devel@...ts.openwrt.org>,
 Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH net-next] net: lantiq_etop: remove driver

On 1/29/2026 6:18 PM, Heiner Kallweit wrote:
> This driver in mainline lost its in-tree user with commit cd93b4895ea5
> ("MIPS: lantiq: drop mips_machine support") in 2012. Since then it has
> had no in-tree user. Only user seems to be OpenWRT, with several changes
> to the in-tree driver version:
> target/linux/lantiq/patches-6.12/035-owrt-lantiq-wifi-and-ethernet-eeprom-handling.patch
> target/linux/lantiq/patches-6.12/028-NET-lantiq-various-etop-fixes.patch
> target/linux/lantiq/patches-6.12/701-NET-lantiq-etop-of-mido.patch
> So it seems the driver is maintained in OpenWrt only, except tree-wide
> in-tree changes. According to OpenWRT maintainers it would be ok to
> remove the driver in mainline and keep it downstream only (see linked
> conversation).
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Link: https://lore.kernel.org/netdev/d80fef86-ba14-4bd4-bce5-4d61a75d591b@hauke-m.de/T/#t
> ---
>  .../include/asm/mach-lantiq/lantiq_platform.h |  18 -
>  drivers/net/ethernet/Kconfig                  |   6 -
>  drivers/net/ethernet/Makefile                 |   1 -
>  drivers/net/ethernet/lantiq_etop.c            | 745 ------------------
>  4 files changed, 770 deletions(-)
>  delete mode 100644 arch/mips/include/asm/mach-lantiq/lantiq_platform.h
>  delete mode 100644 drivers/net/ethernet/lantiq_etop.c
> 
> diff --git a/arch/mips/include/asm/mach-lantiq/lantiq_platform.h b/arch/mips/include/asm/mach-lantiq/lantiq_platform.h
> deleted file mode 100644
> index 70ebb4d6f05..00000000000
> --- a/arch/mips/include/asm/mach-lantiq/lantiq_platform.h
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/*
> - *
> - *  Copyright (C) 2010 John Crispin <john@...ozen.org>
> - */
> -
> -#ifndef _LANTIQ_PLATFORM_H__
> -#define _LANTIQ_PLATFORM_H__
> -
> -#include <linux/socket.h>
> -
> -/* struct used to pass info to network drivers */
> -struct ltq_eth_data {
> -	struct sockaddr mac;
> -	int mii_mode;
> -};
> -
> -#endif
> diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
> index aa7103e7f47..9775fd401b0 100644
> --- a/drivers/net/ethernet/Kconfig
> +++ b/drivers/net/ethernet/Kconfig
> @@ -93,12 +93,6 @@ config KORINA
>  	  If you have a Mikrotik RouterBoard 500 or IDT RC32434
>  	  based system say Y. Otherwise say N.
>  
> -config LANTIQ_ETOP
> -	tristate "Lantiq SoC ETOP driver"
> -	depends on SOC_TYPE_XWAY
> -	help
> -	  Support for the MII0 inside the Lantiq SoC
> -
AI review complained that setting this config symbol should be
removed from arch/mips/configs/xway_defconfig. So I'll submit a v2.

--
pw-bot: cr