netdev - Re: [Question] Dead code in rawv6_mh_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260131100435.36c2aa34@kernel.org>
Date: Sat, 31 Jan 2026 10:04:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ingyu Jang <ingyujang25@...ea.ac.kr>
Cc: netdev@...r.kernel.org, davem@...emloft.net, dsahern@...nel.org,
 edumazet@...gle.com
Subject: Re: [Question] Dead code in rawv6_mh_filter_register()?

On Sun,  1 Feb 2026 00:02:12 +0900 Ingyu Jang wrote:
> Since rawv6_mh_filter_register() never fails, this error path
> appears to be dead code. The same applies to
> rawv6_mh_filter_unregister() in mip6_fini().

Please do not send such reports for networking.
register and alloc functions should always be assumed to
need error handling, so that we don't have to fix all
the callers once they do and check why there's no error 
checking when reviewing the code..