netdev - Re: [PATCH bpf-next v4 02/16] bpf: Convert bpf_selem_unlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <978ac9073e0fadb08c40399bbff7d78cfa4a826ef98911fd654318a9ef9725b4@mail.kernel.org>
Date: Sat, 31 Jan 2026 05:33:31 +0000 (UTC)
From: bot+bpf-ci@...nel.org
To: ameryhung@...il.com,bpf@...r.kernel.org
Cc: netdev@...r.kernel.org,alexei.starovoitov@...il.com,andrii@...nel.org,daniel@...earbox.net,memxor@...il.com,martin.lau@...nel.org,kpsingh@...nel.org,yonghong.song@...ux.dev,song@...nel.org,haoluo@...gle.com,ameryhung@...il.com,kernel-team@...a.com,ast@...nel.org,andrii@...nel.org,daniel@...earbox.net,martin.lau@...nel.org,eddyz87@...il.com,yonghong.song@...ux.dev,clm@...a.com,ihor.solodrai@...ux.dev
Subject: Re: [PATCH bpf-next v4 02/16] bpf: Convert bpf_selem_unlink_map to failable

commit 82de4fd08a55cc944c23c9ae889ed792870964d9
Author: Amery Hung <ameryhung@...il.com>

bpf: Convert bpf_selem_unlink_map to failable

This commit converts bpf_selem_unlink_map() to return an int (always 0 for
now) in preparation for changing bpf_local_storage_map_bucket::lock to
rqspinlock. It introduces _nolock helper variants and extends critical
sections to ensure atomic link/unlink operations.

> Remove the selem_linked_to_map_lockless() check as an selem in the
> commom paths (not bpf_local_storage_map_free() or

This isn't a bug, but there's a typo here: "commom" should be "common".

---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21539340647

AI-authorship-score: low
AI-authorship-explanation: The commit demonstrates deep BPF subsystem knowledge, contains a human-typical typo, and is part of a coherent patch series - all indicators of human authorship.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: Minor typo in commit message (commom should be common) - no functional impact.