netdev - Re: [PATCH net 0/2] gve: fix crashes on invalid TX queue indices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260130163825.3b63222a@kernel.org>
Date: Fri, 30 Jan 2026 16:38:25 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, Ankit Garg <nktgrg@...gle.com>
Cc: Joshua Washington <joshwash@...gle.com>, netdev@...r.kernel.org,
 Harshitha Ramamurthy <hramamurthy@...gle.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Paolo
 Abeni <pabeni@...hat.com>, Willem de Bruijn <willemb@...gle.com>, Praveen
 Kaligineedi <pkaligineedi@...gle.com>, Catherine Sullivan
 <csully@...gle.com>, Luigi Rizzo <lrizzo@...gle.com>, Jon Olson
 <jonolson@...gle.com>, Sagi Shahar <sagis@...gle.com>, Bailey Forrest
 <bcf@...gle.com>, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net 0/2] gve: fix crashes on invalid TX queue indices

On Fri, 30 Jan 2026 21:56:07 +0100 Eric Dumazet wrote:
> Jakub, the issue is that before 4.20, calling synchronize_rcu()
> instead of synchronize_rcu_bh()
> was probably a bug. I suspect we had more issues like that.
> 
>  __dev_queue_xmit takes a rcu_read_lock_bh(), while the code (that you
> added in 2018 [1])
> to update the queue netif_set_real_num_tx_queues does synchronize_net()
> (aka synchronize_rcu()) and in earlier times, it would mean that this
> would maybe return too soon (say on preemptible kernels)
> 
> [...]
> 
> So perhaps a fix for pre 4.20 kernel would be: (I kept the
> synchronize_net() to be really cautious and because I really do not
> want to test)

Sounds entirely plausible, FWIW. Ankit, this would mean that you have
to convince RHEL / Rocky to take Eric's patch. Oldest kernel we can
patch upstream is 5.10, AFAIK.