netdev - Re: [PATCH net-next 1/8] ipv6: pass proto by value to ipv6_push_nfrag_opts() and ipv6_push_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUCrLxU3deQ7UY_RwW6tqa975qDPS5AwRHbxt2hO9EtLzQ@mail.gmail.com>
Date: Fri, 30 Jan 2026 22:29:28 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, David Ahern <dsahern@...nel.org>, 
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 1/8] ipv6: pass proto by value to
 ipv6_push_nfrag_opts() and ipv6_push_frag_opts()

On Fri, Jan 30, 2026 at 1:03 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> With CONFIG_STACKPROTECTOR_STRONG=y, it is better to avoid passing
> a pointer to an automatic variable.
>
> Change these exported functions to return 'u8 proto'
> instead of void.
>
> - ipv6_push_nfrag_opts()
> - ipv6_push_frag_opts()
>
> For instance, replace
>         ipv6_push_frag_opts(skb, opt, &proto);
> with:
>         proto = ipv6_push_frag_opts(skb, opt, proto);
>
> Note that even after this change, ip6_xmit() has to use a stack canary
> because of @first_hop variable.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>