netdev - Re: [PATCH] tipc: fix RCU dereference race in tipc_aead_users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANn89iKZaoJV-zRLzB7jrrkvrun-AqrN+TjxTkNgrKeB3uML8A@mail.gmail.com>
Date: Sun, 1 Feb 2026 10:48:05 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Daniel Hodges <hodgesd@...a.com>
Cc: Jon Maloy <jmaloy@...hat.com>, "David S . Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Ying Xue <ying.xue@...dreiver.com>, Tuong Lien <tuong.t.lien@...tech.com.au>, 
	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] tipc: fix RCU dereference race in tipc_aead_users_dec()

On Sun, Feb 1, 2026 at 3:31 AM Daniel Hodges <hodgesd@...a.com> wrote:
>
> tipc_aead_users_dec() calls rcu_dereference(aead) twice: once to store
> in 'tmp' for the NULL check, and again inside the atomic_add_unless()
> call.
>
> Use the already-dereferenced 'tmp' pointer consistently, matching the
> correct pattern used in tipc_aead_users_inc() and tipc_aead_users_set().
>
> Fixes: fc1b6d6de220 ("tipc: introduce TIPC encryption & authentication")
> Cc: stable@...r.kernel.org
>
> Signed-off-by: Daniel Hodges <hodgesd@...a.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>