netdev - Re: [PATCH net-next v8 11/16] netkit: Implement rtnl_link_ops->alloc and ndo_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260131161903.064b5cb2@kernel.org>
Date: Sat, 31 Jan 2026 16:19:03 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Borkmann <daniel@...earbox.net>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
 razor@...ckwall.org, pabeni@...hat.com, willemb@...gle.com,
 sdf@...ichev.me, john.fastabend@...il.com, martin.lau@...nel.org,
 jordan@...fe.io, maciej.fijalkowski@...el.com, magnus.karlsson@...el.com,
 dw@...idwei.uk, toke@...hat.com, yangzhenze@...edance.com,
 wangdongdong.6@...edance.com
Subject: Re: [PATCH net-next v8 11/16] netkit: Implement
 rtnl_link_ops->alloc and ndo_queue_create

On Thu, 29 Jan 2026 23:28:25 +0100 Daniel Borkmann wrote:
> +	if (netif_running(dev))
> +		netif_carrier_off(dev);
> +	err = netif_set_real_num_rx_queues(dev, rxq_count_new);
> +	if (netif_running(dev))
> +		netif_carrier_on(dev);

Why do we need to flap the carrier?
(If there's a reason perhaps add a comment?)