netdev - Re: [PATCH net-next] net: marvell: prestera: fix FEC error message for SFP ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <795c3351-d65b-4a9a-83dc-b530177b9d28@gmail.com>
Date: Mon, 2 Feb 2026 11:26:00 +0100
From: Jonas Gorski <jonas.gorski@...il.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, tchornyi@...vell.com,
 vmytnyk@...vell.com, yevhen.orlov@...ision.eu, vkochan@...vell.com,
 taras.chornyi@...ision.eu, pabeni@...hat.com, kuba@...nel.org,
 edumazet@...gle.com, davem@...emloft.net, andrew+netdev@...n.ch,
 netdev@...r.kernel.org
Cc: alok.a.tiwarilinux@...il.com
Subject: Re: [PATCH net-next] net: marvell: prestera: fix FEC error message
 for SFP ports

Hi,

On 02/02/2026 06:28, Alok Tiwari wrote:
> In prestera_ethtool_set_fecparam(), the error message is opposite of
> the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is
> not allowed on SFP ports, but the message says "non-SFP ports", which
> does not match the condition.
> 
> Fix the message to match the condition.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> index 2f52daba58e6..a259da9f30f4 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> @@ -718,7 +718,7 @@ static int prestera_ethtool_set_fecparam(struct net_device *dev,
>  	}
>  
>  	if (port->caps.transceiver == PRESTERA_PORT_TCVR_SFP) {
> -		netdev_err(dev, "FEC set is not allowed on non-SFP ports\n");
> +		netdev_err(dev, "FEC set is not allowed on SFP ports\n");
>  		return -EINVAL;
>  	}
>  

I'm pretty sure that the condition here is wrong, not the error message.

AFAIK it doesn't make sense to configure FEC on ethernet/copper ports,
but for SFP ports, it may be required depending on the transceiver or
cable used, especially for fiber modules.

I may be wrong though.

This check was introduced with bb5dbf2cc64d ("net: marvell: prestera:
add firmware v4.0 support"), but that commit does not offer any
explanation for it in the commit message.

Best regards,
Jonas