netdev - Re: [PATCH net-next v7 02/11] net: tunnel: convert iptunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3a7f4b4-3569-422b-873f-0f4e1f11392b@redhat.com>
Date: Tue, 3 Feb 2026 09:21:08 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Marek Mietus <mmietus97@...oo.com>, netdev@...r.kernel.org,
 sd@...asysnail.net, kuba@...nel.org
Cc: Jason@...c4.com
Subject: Re: [PATCH net-next v7 02/11] net: tunnel: convert iptunnel_xmit to
 noref

On 1/27/26 8:04 AM, Marek Mietus wrote:
> diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
> index cf37ad9686e6..a0d699082747 100644
> --- a/net/ipv6/sit.c
> +++ b/net/ipv6/sit.c
> @@ -1028,6 +1028,7 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb,
>  
>  	iptunnel_xmit(NULL, rt, skb, fl4.saddr, fl4.daddr, protocol, tos, ttl,
>  		      df, !net_eq(tunnel->net, dev_net(dev)), 0);
> +	ip_rt_put(rt);
>  	return NETDEV_TX_OK;
>  
>  tx_error_icmp:

Could you please double check that all ndo_start_xmit caller are under
RCU protection?

Specifically I don't see it in the
xsk_generic_xmit()/__dev_direct_xmit() path.

/P