netdev - Re: [PATCH net-next v4] net: usb: introduce usbnet_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADkSEUgmX1tk-qJ7ee=P3EYcvriW91nVJZ6AFDpVEVjj7O8pJg@mail.gmail.com>
Date: Tue, 3 Feb 2026 00:49:57 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-usb@...r.kernel.org, netdev@...r.kernel.org, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Andrew Lunn <andrew@...n.ch>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Peter Korsgaard <peter@...sgaard.com>, Steve Glendinning <steve.glendinning@...well.net>, 
	Oliver Neukum <oneukum@...e.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Oleksij Rempel <o.rempel@...gutronix.de>, Max Schulze <max.schulze@...ine.de>, 
	Krzysztof Hałasa <khalasa@...p.pl>
Subject: Re: [PATCH net-next v4] net: usb: introduce usbnet_mii_ioctl helper function

Hi, Andy,

On Tue, Feb 3, 2026 at 12:25 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> > +extern int usbnet_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd);
>
> Do we still need to populate 'extern'? Can we get rid of this redundancy?
In my opinion, while you're right that it isn't necessary because all
functions (unlike variables) are implied to be extern, the use of
extern to indicate functions that are exported/intended to be part of
the API is a good idea.

Ethan