netdev - Re: [PATCH net v3] net: spacemit: k1-emac: fix jumbo frame support: manual merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4819ec3b-23b4-447b-b10b-0bd93a40dc5a@kernel.org>
Date: Tue, 3 Feb 2026 10:39:02 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Tomas Hlavacek <tmshlvck@...il.com>, netdev@...r.kernel.org
Cc: linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, dlan@...nel.org, wangruikang@...as.ac.cn,
 stable@...r.kernel.org, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH net v3] net: spacemit: k1-emac: fix jumbo frame support:
 manual merge

Hello,

+cc: Mark for Linux Next

On 30/01/2026 11:23, Tomas Hlavacek wrote:
> The driver never programs the MAC frame size and jabber registers,
> causing the hardware to reject frames larger than the default 1518
> bytes even when larger DMA buffers are allocated.
> 
> Program MAC_MAXIMUM_FRAME_SIZE, MAC_TRANSMIT_JABBER_SIZE, and
> MAC_RECEIVE_JABBER_SIZE based on the configured MTU. Also fix the
> maximum buffer size from 4096 to 4095, since the descriptor buffer
> size field is only 12 bits. Account for double VLAN tags in frame
> size calculations.

FYI, we got a small conflict when merging 'net' in 'net-next' in the
MPTCP tree due to this patch applied in 'net':

  3125fc170169 ("net: spacemit: k1-emac: fix jumbo frame support")

and this one from 'net-next':

  f66086798f91 ("net: spacemit: Remove broken flow control support")

----- Generic Message -----
The best is to avoid conflicts between 'net' and 'net-next' trees but if
they cannot be avoided when preparing patches, a note about how to fix
them is much appreciated.

The conflict has been resolved on our side [1] and the resolution we
suggest is attached to this email. Please report any issues linked to
this conflict resolution as it might be used by others. If you worked on
the mentioned patches, don't hesitate to ACK this conflict resolution.
---------------------------

Regarding this conflict, both commits modified independent code from the
same context: code related to the flow control has been removed, and the
one to frame/jabber size has been added.

Rerere cache is available in [2].

Cheers,
Matt

1: https://github.com/multipath-tcp/mptcp_net-next/commit/286ef2be604b
2: https://github.com/multipath-tcp/mptcp-upstream-rr-cache/commit/45e15

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

View attachment "286ef2be604bcb5d4ec28bb2d194865f61a52088.patch" of type "text/x-patch" (1565 bytes)