netdev - Re: [PATCH net 1/3] Revert "net: ag71xx: use devm for register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfwuhrUZiFp5v0EjbMJw0fYZTfznqPN_6yuMWxnD4ircQ@mail.gmail.com>
Date: Tue, 3 Feb 2026 11:28:59 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Chris Snook <chris.snook@...il.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net 1/3] Revert "net: ag71xx: use devm for register_netdev"

On Mon, Feb 2, 2026 at 10:48 PM Rosen Penev <rosenp@...il.com> wrote:
>
> This reverts commit cc20a4791641a1cbd1525695fac0d4725dd72509.
>
> register_netdev gets called after phylink_create which has no devm
> equivalent. phylink_destroy must be called after unregister_netdev and
> not before.
>
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---

Can we just use devm_add_action_or_reset() with a callback calling
phylink_destroy()? It will surely make error handling in probe easier
and avoid mixing devm and non-managed APIs.

Bart