netdev - Re: [Intel-wired-lan] [iwl-next, v5, 3/3] igb: allow configuring RSS key via ethtool set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260203123136.25423-2-takkozu@amazon.com>
Date: Tue, 3 Feb 2026 21:31:37 +0900
From: Takashi Kozu <takkozu@...zon.com>
To: <horms@...nel.org>
CC: <aleksandr.loktionov@...el.com>, <andrew+netdev@...n.ch>,
	<anthony.l.nguyen@...el.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<enjuk@...zon.com>, <intel-wired-lan@...ts.osuosl.org>, <kuba@...nel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <piotr.kwapulinski@...el.com>,
	<pmenzel@...gen.mpg.de>, <przemyslaw.kitszel@...el.com>, <takkozu@...zon.com>
Subject: Re: [Intel-wired-lan] [iwl-next, v5, 3/3] igb: allow configuring RSS key via ethtool set_rxfh

> From: Simon Horman <horms@...nel.org>
> To: takkozu@...zon.com
> Cc: Simon Horman <horms@...nel.org>,
> anthony.l.nguyen@...el.com, andrew+netdev@...n.ch,
> davem@...emloft.net, aleksandr.loktionov@...el.com,
> przemyslaw.kitszel@...el.com, kuba@...nel.org,
> netdev@...r.kernel.org, enjuk@...zon.com, pabeni@...hat.com,
> intel-wired-lan@...ts.osuosl.org, edumazet@...gle.com,
> piotr.kwapulinski@...el.com, pmenzel@...gen.mpg.de
> Subject: Re: [iwl-next,v5,3/3] igb: allow configuring RSS key via ethtool set_rxfh
> Date: Mon, 2 Feb 2026 10:25:20 +0000 [thread overview]
> Message-ID: <20260202102520.1844644-1-horms@...nel.org> (raw)
> In-Reply-To: <20260127085410.79645-8-takkozu@...zon.com>
> 
> This is an AI-generated review of your patch. The human sending this
> email says "I'm releasing this report for completeness. And while I
> do think it is correct. I don't think it needs to block progress"
> 
> For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
> ---
> igb: allow configuring RSS key via ethtool set_rxfh
> 
> This patch adds support for configuring the RSS key via ethtool's
> set_rxfh interface. The change accepts a userspace-provided RSS key,
> stores it in the adapter structure, and writes it to hardware registers.
> 
> > Change igc_set_rxfh() to accept and save a userspace-provided
> > RSS key.
> 
> This isn't a code bug, but the commit message references "igc_set_rxfh()"
> when the function being modified is actually igb_set_rxfh() in
> drivers/net/ethernet/intel/igb/igb_ethtool.c. This typo was noted by
> Aleksandr Loktionov in the v1 review:
> https://lore.kernel.org/intel-wired-lan/IA3PR11MB89860A16782937C7E8C2E2DEE5A7A@IA3PR11MB8986.namprd11.prod.outlook.com/
> 
> Should this be corrected to igb_set_rxfh() to match the actual code?

Thank you for pointing out.
I'll fix it and send it as v6.