netdev - Re: [PATCH net-next 3/3] tcp: make tcp_v{4,6}_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260203092636.20c6bb6e@kernel.org>
Date: Tue, 3 Feb 2026 09:26:36 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Neal Cardwell
 <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>,
 netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/3] tcp: make tcp_v{4,6}_send_check() static

On Tue,  3 Feb 2026 14:40:53 +0000 Eric Dumazet wrote:
> tcp_v{4,6}_send_check() are only called from tcp_output.c
> and should be made static so that the compiler does not need
> to put an out of line copy of them.
> 
> Remove (struct inet_connection_sock_af_ops) send_check field
> and use instead @net_header_len.
> 
> Move @net_header_len close to @queue_xmit for data locality
> as both are used in TCP tx fast path.

Seeing this in allmodconfig:

net/ipv4/tcp_output.c:1482:13: warning: unused function 'tcp_v4_send_check' [-Wunused-function]
 1482 | static void tcp_v4_send_check(struct sock *sk, struct sk_buff *skb)
      |             ^~~~~~~~~~~~~~~~~
-- 
pw-bot: cr