netdev - Re: [net-next,v3,03/11] net: phy: phy_link_topology: Track ports in phy_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <669d63db-2507-4020-bfe7-319159b710d5@bootlin.com>
Date: Tue, 3 Feb 2026 19:11:30 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Simon Horman <horms@...nel.org>
Cc: hkallweit1@...il.com, nicveronese@...il.com, f.fainelli@...il.com,
 pabeni@...hat.com, edumazet@...gle.com, dimitri.fedrau@...bherr.com,
 thomas.petazzoni@...tlin.com, kabel@...nel.org, kuba@...nel.org,
 vladimir.oltean@....com, andrew@...n.ch, davem@...emloft.net,
 romain.gantois@...tlin.com, linux-kernel@...r.kernel.org,
 o.rempel@...gutronix.de, linux@...linux.org.uk, kory.maincent@...tlin.com,
 mwojtas@...omium.org, christophe.leroy@...roup.eu, herve.codina@...tlin.com,
 netdev@...r.kernel.org, daniel@...rotopia.org
Subject: Re: [net-next,v3,03/11] net: phy: phy_link_topology: Track ports in
 phy_link_topology

Hi Simon,

On 03/02/2026 19:02, Simon Horman wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.

> 
> xa_alloc_cyclic() returns 1 when ID allocation wraps around, which is still a
> successful allocation. The check at line 126 above correctly uses `if (ret < 0)`
> for the phyindex allocation:

I already reported that to Chris, this review is incorrect.

xa_alloc_cyclic() doesn't return 1 upon wraparound. __xa_alloc_cyclic()
does :)

Maxime