netdev - Re: [PATCH v2 net] bonding: only set speed/duplex to unknown, if getting speed failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ce5f52b-faa3-4d5e-afc7-08544bd8e241@blackwall.org>
Date: Tue, 3 Feb 2026 20:48:08 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Thomas Bogendoerfer <tbogendoerfer@...e.de>,
 Jay Vosburgh <jv@...sburgh.net>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Weiping Pan <wpan@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] bonding: only set speed/duplex to unknown, if
 getting speed failed

On 03/02/2026 16:11, Thomas Bogendoerfer wrote:
> bond_update_speed_duplex() first set speed/duplex to unknown and
> then asks slave driver for current speed/duplex. Since getting
> speed/duplex might take longer there is a race, where this false state
> is visible by /proc/net/bonding. With commit 691b2bf14946 ("bonding:
>   update port speed when getting bond speed") this race gets more visible,
> if user space is calling ethtool on a regular base.
> 
> Fix this by only setting speed/duplex to unknown, if link speed is
> really unknown/unusable.
> 
> Fixes: 98f41f694f46 ("bonding:update speed/duplex for NETDEV_CHANGE")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> ---
> v2: corrected fixes tag
> v1: https://lore.kernel.org/all/20260130111904.144024-1-tbogendoerfer@suse.de/
> 
>   drivers/net/bonding/bond_main.c | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)
> 

Please CC all people who were involved in the previous patch version review.
Looks good to me,
Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>