netdev - Re: [PATCH v2 net-next 4/4] tcp: move __reqsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUDO0YnweO9MQZ5wjEzzNi_WsJSraC4FgaMPkH7_m-EODQ@mail.gmail.com>
Date: Tue, 3 Feb 2026 23:37:38 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 4/4] tcp: move __reqsk_free() out of line

On Tue, Feb 3, 2026 at 9:51 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> Inlining __reqsk_free() is overkill, let's reclaim 2 Kbytes of text.
>
> $ scripts/bloat-o-meter -t vmlinux.old vmlinux.new
> add/remove: 2/4 grow/shrink: 2/14 up/down: 225/-2338 (-2113)
> Function                                     old     new   delta
> __reqsk_free                                   -     114    +114
> sock_edemux                                   18      82     +64
> inet_csk_listen_start                        233     264     +31
> __pfx___reqsk_free                             -      16     +16
> __pfx_reqsk_queue_alloc                       16       -     -16
> __pfx_reqsk_free                              16       -     -16
> reqsk_queue_alloc                             46       -     -46
> tcp_req_err                                  272     177     -95
> reqsk_fastopen_remove                        348     253     -95
> cookie_bpf_check                             157      62     -95
> cookie_tcp_reqsk_alloc                       387     290     -97
> cookie_v4_check                             1568    1465    -103
> reqsk_free                                   105       -    -105
> cookie_v6_check                             1519    1412    -107
> sock_gen_put                                 187      78    -109
> sock_pfree                                   212      82    -130
> tcp_try_fastopen                            1818    1683    -135
> tcp_v4_rcv                                  3478    3294    -184
> reqsk_put                                    306      90    -216
> tcp_get_cookie_sock                          551     318    -233
> tcp_v6_rcv                                  3404    3141    -263
> tcp_conn_request                            2677    2384    -293
> Total: Before=24887415, After=24885302, chg -0.01%
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>