netdev - Re: [PATCH net 2/2] gve: Correct ethtool rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bc348ed-3ed2-4eea-8527-44b082f7be25@intel.com>
Date: Tue, 3 Feb 2026 17:42:47 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Harshitha Ramamurthy <hramamurthy@...gle.com>, <netdev@...r.kernel.org>
CC: <joshwash@...gle.com>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<willemb@...gle.com>, <ziweixiao@...gle.com>, <jordanrhee@...gle.com>,
	<nktgrg@...gle.com>, <kuozhao@...gle.com>, <yangchun@...gle.com>,
	<awogbemila@...gle.com>, <maolson@...gle.com>, <ast@...nel.org>,
	<daniel@...earbox.net>, <hawk@...nel.org>, <john.fastabend@...il.com>,
	<sdf@...ichev.me>, <bpf@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.com>, Max Yuan <maxyuan@...gle.com>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH net 2/2] gve: Correct ethtool rx_dropped calculation



On 2/2/2026 11:39 AM, Harshitha Ramamurthy wrote:
> From: Max Yuan <maxyuan@...gle.com>
> 
> The gve driver's "rx_dropped" statistic, exposed via `ethtool -S`,
> incorrectly includes `rx_buf_alloc_fail` counts. These failures
> represent an inability to allocate receive buffers, not true packet
> drops where a received packet is discarded. This misrepresentation can
> lead to inaccurate diagnostics.
> 
> This patch rectifies the ethtool "rx_dropped" calculation. It removes
> `rx_buf_alloc_fail` from the total and adds `xdp_tx_errors` and
> `xdp_redirect_errors`, which represent legitimate packet drops within
> the XDP path.
> 
> Cc: stable@...r.kernel.org
> Fixes: 433e274b8f7b ("gve: Add stats for gve.")
> Signed-off-by: Max Yuan <maxyuan@...gle.com>
> Reviewed-by: Jordan Rhee <jordanrhee@...gle.com>
> Reviewed-by: Joshua Washington <joshwash@...gle.com>
> Reviewed-by: Matt Olson <maolson@...gle.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>