netdev - Re: [EXTERNAL] [PATCH net-next 0/2] net: ti: icssg: Remove dedicated workqueue for ndo_set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <583feb00-09a8-4008-ae50-b6f3e3f990ba@ti.com>
Date: Wed, 4 Feb 2026 16:44:21 +0530
From: Meghana Malladi <m-malladi@...com>
To: Kevin Hao <haokexin@...il.com>, <netdev@...r.kernel.org>
CC: MD Danish Anwar <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Jacob Keller <jacob.e.keller@...el.com>, "Vadim
 Fedorenko" <vadim.fedorenko@...ux.dev>, Himanshu Mittal <h-mittal1@...com>,
	Simon Horman <horms@...nel.org>, Byungchul Park <byungchul@...com>, "Markus
 Elfring" <elfring@...rs.sourceforge.net>
Subject: Re: [EXTERNAL] [PATCH net-next 0/2] net: ti: icssg: Remove dedicated
 workqueue for ndo_set_rx_mode callback

Hi Kevin,

On 2/4/26 08:11, Kevin Hao wrote:
> While addressing an issue in the cpsw driver, I based my fix on the 
> implementation of the emac_ndo_set_rx_mode() function in icssg. During 
> review, Jakub pointed out that the dedicated workqueue for the 
> ndo_set_rx_mode callback might be unnecessary. 
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source 
> of this email and know the content is safe.
> Report Suspicious
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK! 
> uxdqXRfPtm1bKoXPFrvrtsCD2dIkXHVJwEzupcwg1k-qY0e_2PUuMdZgJf- 
> SUVShc4kuXcBnqQbeqGz1dHBW-_OSdROPAjSiNpSTmAhDg8nQbc8$>
> ZjQcmQRYFpfptBannerEnd
> 
> While addressing an issue in the cpsw driver, I based my fix on the
> implementation of the emac_ndo_set_rx_mode() function in icssg. During review,
> Jakub pointed out that the dedicated workqueue for the ndo_set_rx_mode
> callback might be unnecessary. I subsequently used the system workqueue for
> this purpose in the cpsw driver, and it performed as expected. Therefore,
> I believe the same approach can be applied to the icssg driver. These two
> patches aim to remove this dedicated workqueue for icssg drivers.
> 

It would be more helpful, if you could provide link to the cpsw fix 
which you have mentioned above.

> Please note: I do not have access to a board that supports the CSSG PRU
> Ethernet controller, so this change has only been build-tested.
> 
> ---
> Cc: MD Danish Anwar <danishanwar@...com>
> Cc: Roger Quadros <rogerq@...nel.org>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Meghana Malladi <m-malladi@...com>
> Cc: Jacob Keller <jacob.e.keller@...el.com>
> Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Cc: Himanshu Mittal <h-mittal1@...com>
> Cc: Simon Horman <horms@...nel.org>
> Cc: Byungchul Park <byungchul@...com>
> Cc: Markus Elfring <elfring@...rs.sourceforge.net>
> 
> ---
> Kevin Hao (2):
>        net: ti: icssg-prueth-sr1: Remove unused workqueue
>        net: ti: icssg-prueth: Use system default workqueue in ndo_set_rx_mode callback
> 
>   drivers/net/ethernet/ti/icssg/icssg_common.c     |  1 -
>   drivers/net/ethernet/ti/icssg/icssg_prueth.c     | 13 ++++---------
>   drivers/net/ethernet/ti/icssg/icssg_prueth.h     |  1 -
>   drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c |  9 +--------
>   4 files changed, 5 insertions(+), 19 deletions(-)
> ---
> base-commit: 5c009020744fe129e4728e71c44a6c7816c9105e
> change-id: 20260203-icssg-prueth-workqueue-f460eba72132
> 
> Best regards,
> -- 
> Kevin Hao <haokexin@...il.com>
> 

Thanks,
Meghana