netdev - RE: [PATCH net-next v1 1/7] net: ngbe: move the WOL functions to libwx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06ee01dc957a$abe802d0$03b80870$@trustnetic.com>
Date: Wed, 4 Feb 2026 10:05:01 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Andrew Lunn'" <andrew@...n.ch>
Cc: <netdev@...r.kernel.org>,
	"'Andrew Lunn'" <andrew+netdev@...n.ch>,
	"'David S. Miller'" <davem@...emloft.net>,
	"'Eric Dumazet'" <edumazet@...gle.com>,
	"'Jakub Kicinski'" <kuba@...nel.org>,
	"'Paolo Abeni'" <pabeni@...hat.com>,
	"'Simon Horman'" <horms@...nel.org>,
	"'Mengyuan Lou'" <mengyuanlou@...-swift.com>,
	<netdev@...r.kernel.org>,
	"'Andrew Lunn'" <andrew+netdev@...n.ch>,
	"'David S. Miller'" <davem@...emloft.net>,
	"'Eric Dumazet'" <edumazet@...gle.com>,
	"'Jakub Kicinski'" <kuba@...nel.org>,
	"'Paolo Abeni'" <pabeni@...hat.com>,
	"'Simon Horman'" <horms@...nel.org>,
	"'Mengyuan Lou'" <mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next v1 1/7] net: ngbe: move the WOL functions to libwx

 On Tue, Feb 3, 2026 9:53 PM, Andrew Lunn wrote:
> > -	ncsi_mask = wx->subsystem_device_id & NGBE_NCSI_MASK;
> > -	wol_mask = wx->subsystem_device_id & NGBE_WOL_MASK;
> > +	ncsi_mask = wx->subsystem_device_id & WX_NCSI_MASK;
> > +	wol_mask = wx->subsystem_device_id & WX_WOL_MASK;
> 
> The ncsi_mask change seems like it should not be here. This patch is
> about WoL.
> 

I'll split it, thanks.