netdev - Re: [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9859fe54fded87e720e375b1b267908437480f47.camel@kernel.org>
Date: Wed, 04 Feb 2026 09:28:28 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Chuck Lever	
 <chuck.lever@...cle.com>, NeilBrown <neil@...wn.name>, 
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, 	llvm@...ts.linux.dev
Cc: Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>, 
 Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom
 Talpey <tom@...pey.com>, "David S. Miller"	 <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski	 <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman	 <horms@...nel.org>, Nathan
 Chancellor <nathan@...nel.org>, Nick Desaulniers	
 <nick.desaulniers+lkml@...il.com>, Bill Wendling <morbo@...gle.com>, Justin
 Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v2 0/3] sunrpc: Fix `make W=1` build issues

On Wed, 2026-02-04 at 10:41 +0100, Andy Shevchenko wrote:
> Compiler is not happy about unused variables (especially when
> dprintk() call is defined as no-op). Here is the series to
> address the issues.
> 
> Changelog v2:
> - added patch to kill RPC_IFDEBUG() macro (LKP, Geert)
> - united separate patches in the series
> - collected tags (Geert)
> 
> v1: 20260204010402.2149563-1-andriy.shevchenko@...ux.intel.com
> v1: 20260204010415.2149607-1-andriy.shevchenko@...ux.intel.com
> 
> Andy Shevchenko (3):
>   nfs/blocklayout: Fix compilation error (`make W=1`) in
>     bl_write_pagelist()
>   sunrpc: Kill RPC_IFDEBUG()
>   sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op
> 
>  fs/lockd/svclock.c                       |  5 +++++
>  fs/nfs/blocklayout/blocklayout.c         |  4 +---
>  fs/nfsd/nfsfh.c                          |  9 +++++---
>  include/linux/sunrpc/debug.h             | 10 +++++----
>  net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------
>  5 files changed, 32 insertions(+), 23 deletions(-)

These all look like good changes to me. The first patch should go to
Trond/Anna and Chuck will probably pick up the other two?

Reviewed-by: Jeff Layton <jlayton@...nel.org>