netdev - Re: [PATCH v2] netfilter: amanda: fix RCU pointer typing for nf_nat_amanda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABFUUZG2uPmCo=wiPe-p0YmhjwEpubmVOHUd6wJ3QtArh=pOJA@mail.gmail.com>
Date: Wed, 4 Feb 2026 22:49:20 +0800
From: sun jian <sun.jian.kdev@...il.com>
To: Florian Westphal <fw@...len.de>
Cc: Pablo Neira Ayuso <pablo@...filter.org>, Phil Sutter <phil@....cc>, Simon Horman <horms@...nel.org>, 
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] netfilter: amanda: fix RCU pointer typing for nf_nat_amanda_hook

On Wed, Feb 4, 2026 at 8:24 PM Florian Westphal <fw@...len.de> wrote:
>
> sun jian <sun.jian.kdev@...il.com> wrote:
> > To keep the code concise while stripping the RCU attribute, I'll use
> > the typeof(*hook) * pattern
>
> No, please leave this alone, the code is fine as-is, all sparse warnings
> are due to missing annotations only.
Ack. You are right: I've double-checked  my environment and confirmed
that adding the __rcu is sufficient to resolve those warnings.

I will just annotate them and leave other code as-is. V4 is on the way.

Regards,
sun jian